This repository was archived by the owner on Jan 28, 2021. It is now read-only.
Update to AutoPVT functionality #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_Arduino_Library use .h / .cpp from local disk # Conflicts: # README.md # src/SparkFun_Ublox_Arduino_Library.cpp # src/SparkFun_Ublox_Arduino_Library.h
…e and disable the implicit update of data that happened previously even with autoPVT set to true Changes: - add implicitUpdate parameter to setAutoPVT to control when the actual processing of the data happens - add assumeAutoPVT method for use-cases where the receiver can't be controlled (no UART Tx line from MCU to receiver) - change getPVT to respect autoPVTImplicitUpdate==false - remove "virtual" from getPVT as it is not required anymore after the above changes
|
Looks good and I welcome the PR. Can you add an example demoing the new functionality? Thanks for writing the extra functions so-as to not break anyone's older code (yay reverse compatibility). |
|
And please add any new functions to the keywords.txt so they'll be highlighted. |
|
Hi Nathan, |
add Example16_AutoPVT_ExplicitUpdate.ino -> show how to use explicit updates by calling checkUblox add Example17_AssumeAutoPVTviaUart.ino -> show how to use a Rx only UART connection to receive PVT message
|
Hi Nathan, |
|
Looks great. Examples test ok. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this is a further extension to the original PR 4.
It adds the possibility to choose between implicit updates from the buffer when accessing stale data and an externally driven (cyclic) update.
I tried to make it as unobtrusive as possible by adding another version of setAutoPVT with a third parameter.
The changes include also an assumeAutoPVT in case the GPS is connected via to a Rx line of the MCU only.
I'm running this on an ESP32 device (M5Stack Fire + ublox M8N ) where most of the data is used on a different core and the implicit calls to checkUblox are causing disturbance of other tasks.
Please let me know what you think of this!